Conversation
like i don't know how to build tidbyt / tronbyt apps at all :-)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new applet designed to provide users with timely information about Passover. It intelligently determines whether to display a countdown to the upcoming Passover or to show which day of the 8-day festival is currently active, enhancing the user's ability to observe and celebrate the holiday. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Passover app. Several issues require attention. The app is missing required preview images, which is a high-severity issue that blocks merging. The id in passover.yaml violates naming conventions and is also a high-severity issue. Additionally, the Starlark file contains unused imports and relies on a hardcoded list of dates that will expire.
apps/passover/passover.yaml
Outdated
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| id: passovercountdown | |||
There was a problem hiding this comment.
The app id must match its directory name (passover) per file naming conventions. This is a requirement for the app to be correctly identified by the system.
id: passoverReferences
- The
packageNameattribute in the manifest.yaml file must correspond to the directory name. In this context,idserves as thepackageName. (link)
apps/passover/passover.star
Outdated
| load("schema.star", "schema") | ||
| load("time.star", "time") | ||
| load("http.star", "http") | ||
| load("encoding/json.star", "json") |
There was a problem hiding this comment.
The schema, http, and json modules are loaded but not used. These unused imports should be removed.
| PASSOVER_DATES = [ | ||
| {"year": 2026, "start": "2026-04-01", "end": "2026-04-08"}, | ||
| {"year": 2027, "start": "2027-04-22", "end": "2027-04-29"}, | ||
| {"year": 2028, "start": "2028-04-10", "end": "2028-04-17"}, | ||
| {"year": 2029, "start": "2029-03-31", "end": "2029-04-07"}, | ||
| {"year": 2030, "start": "2030-04-18", "end": "2030-04-25"}, | ||
| {"year": 2031, "start": "2031-04-08", "end": "2031-04-15"}, | ||
| {"year": 2032, "start": "2032-03-27", "end": "2032-04-03"}, | ||
| {"year": 2033, "start": "2033-04-14", "end": "2033-04-21"}, | ||
| {"year": 2034, "start": "2034-04-04", "end": "2034-04-11"}, | ||
| {"year": 2035, "start": "2035-03-24", "end": "2035-03-31"}, | ||
| {"year": 2036, "start": "2036-04-10", "end": "2036-04-17"} | ||
| ] |
There was a problem hiding this comment.
Hardcoding dates limits the app's lifespan. After 2036, this app will only show the default screen. Consider fetching dates from a public API (e.g., api.hebcal.com) to make the app more robust and future-proof.
2 participants
No description provided.